[Backend Tester] Reduce log verbosity / spam #13312
Open
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13312
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 780519f with merge base 3a02146 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 12, 2025
meta-cla
bot
added
the
CLA Signed
This was referenced Aug 12, 2025
digantdesai
reviewed
Aug 12, 2025
| @@ -39,7 +40,9 @@ def graph_module(self) -> None: | |||
|
|
|||
| def run_artifact(self, inputs): | |||
| inputs_flattened, _ = tree_flatten(inputs) | |||
| executorch_module = _load_for_executorch_from_buffer(self.buffer) | |||
| executorch_module = _load_for_executorch_from_buffer( | |||
| self.buffer, program_verification=Verification.Minimal | |||
There was a problem hiding this comment.
what does this do? i.e. Minimal ==> "do the verification but don't print warnings"?
digantdesai
reviewed
Aug 12, 2025
| @@ -249,6 +250,10 @@ def build_test_filter(args: argparse.Namespace) -> TestFilter: | |||
| def runner_main(): | |||
| args = parse_args() | |||
|
|
|||
| # Suppress deprecation warnings for export_for_training, as it generates a | |||
| # lot of log spam. We don't really need the warning here. | |||
| warnings.simplefilter("ignore", category=FutureWarning) | |||
There was a problem hiding this comment.
FYI PyTest has this nice feature where they count same warnings and at the end print warning summary https://docs.pytest.org/en/stable/how-to/capture-warnings.html
digantdesai
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests, deprecation warnings for export_for_training and "internal consistency verification was requested but not available" create a large amount of spam in the CLI and drown out actual test info during the run. Neither warning is particularly useful. I've suppressed the the export_for_training warning in the backend tester only and switched the tester to not request internal consistency verification since it's not compiled into pybindings by default. This gives much cleaner CLI output.
Before:
After: